martin-g commented on code in PR #1672:
URL: https://github.com/apache/avro/pull/1672#discussion_r863657333
##########
lang/rust/avro/src/types.rs:
##########
@@ -355,7 +356,11 @@ impl Value {
}
}
- pub(crate) fn validate_internal(&self, schema: &Schema, names: &NamesRef)
-> Option<String> {
+ pub(crate) fn validate_internal<S: std::borrow::Borrow<Schema>>(
Review Comment:
What is the benefit of using `std::borrow::Borrow` here ?
##########
lang/rust/avro/src/schema.rs:
##########
@@ -434,6 +434,86 @@ impl<'s> ResolvedSchema<'s> {
}
}
+pub(crate) struct ResolvedOwnedSchema {
Review Comment:
Can we avoid the code duplication somehow ?
For example by using `ResolvedSchema.clone()` where needed ?
##########
share/test/data/messageV1/README.md:
##########
@@ -0,0 +1,45 @@
+BinaryMessage data in single object encoding
https://avro.apache.org/docs/current/spec.html#single_object_encoding
+
+Ground truth data generated with Java Code
Review Comment:
OK, the `.bin` file will be pre-generated!
But we should run the new example as part of the interop tests, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
