complone commented on code in PR #1790:
URL: https://github.com/apache/avro/pull/1790#discussion_r931775163


##########
lang/java/avro/src/main/java/org/apache/avro/file/SnappyCodec.java:
##########
@@ -37,7 +40,7 @@ static class Option extends CodecFactory {
 
     @Override
     protected Codec createInstance() {
-      return new SnappyCodec();
+      return SnappyCodec.INSTANCE;

Review Comment:
   @clesaec The code itself is not empty when it is called, and it is empty 
when addCodec adds SnappyCodec, see:
   https://issues.apache.org/jira/browse/AVRO-3590



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to