KalleOlaviNiemitalo commented on PR #1836: URL: https://github.com/apache/avro/pull/1836#issuecomment-1225303643
In Validator, there seems to be some inconsistency with `std::vector<size_t> counters_` and `int64_t count_`, too: - Validator::countingSetup converts int64_t to size_t: `counters_.push_back(static_cast<size_t>(count_));` - Validator::countingAdvance converts size_t to int: `int count = --counters_.back();` - Validator::unionAdvance converts size_t to int64_t: `if (count_ < static_cast<int64_t>(node->leaves()))` - Validator::unionAdvance converts int64_t to int and that to size_t: `setupOperation(node->leafAt(static_cast<int>(count_)));` Those could be fixed in a separate PR, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
