shaeqahmed commented on code in PR #1837:
URL: https://github.com/apache/avro/pull/1837#discussion_r955842066
##########
lang/rust/avro/src/schema.rs:
##########
@@ -684,10 +692,11 @@ impl UnionSchema {
Some((i, &self.schemas[i]))
} else {
// slow path (required for matching logical or named types)
- self.schemas
- .iter()
- .enumerate()
- .find(|(_, schema)| value.validate(schema))
+ self.schemas.iter().enumerate().find(|(_, schema)| {
Review Comment:
Since this cycles through all the variants to find a match, I was seeing a
ton of error logs for every record even when there is no issue. Let me know is
this makes sense, and I can reintroduce this change in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
