zcsizmadia commented on PR #2009: URL: https://github.com/apache/avro/pull/2009#issuecomment-1351525170
My biggest concern is calling the virtual functions from the constructors (see CodeQL complains). I must be addressed before merging. Personally , I feel interfaces are a better solution here, but I understand the concerns about them either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
