martin-g commented on code in PR #2087:
URL: https://github.com/apache/avro/pull/2087#discussion_r1101061294
##########
lang/rust/avro/src/schema.rs:
##########
@@ -611,8 +611,8 @@ impl RecordField {
aliases
.iter()
.flat_map(|alias| alias.as_str())
- .map(|alias| Alias::new(alias).expect("Alias is not
valid"))
- .collect::<Vec<Alias>>()
+ .map(|alias| alias.to_string())
+ .collect::<Vec<String>>()
Review Comment:
Named schema's `aliases` are for the schema's `name` which might be
namespaced.
Record field's aliases are for the field's `name` which is not namespaced.
The field's `type` might be a (namespaced) reference to Schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
