woile commented on code in PR #2014:
URL: https://github.com/apache/avro/pull/2014#discussion_r1132119304
##########
lang/rust/avro/src/reader.rs:
##########
@@ -178,7 +180,13 @@ impl<R: Read> Block<R> {
let mut block_bytes = &self.buf[self.buf_idx..];
let b_original = block_bytes.len();
- let item = from_avro_datum(&self.writer_schema, &mut block_bytes,
read_schema)?;
+ let schemata = if self.schemata.is_empty() {
Review Comment:
personal: I find a `match` more idiomatic for this:
```rs
let schemata = match self.schemata {
None => vec![&self.writer_schema
_ => self.schemata.clone()
}```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
