RikHeijdens commented on code in PR #2394:
URL: https://github.com/apache/avro/pull/2394#discussion_r1277430196
##########
lang/rust/avro/src/types.rs:
##########
@@ -377,11 +377,16 @@ impl Value {
}
}
+ /// Validates the value against the provided schema.
+ ///
+ /// Arguments:
+ /// * `schema_resolution` - whether schema resolution rules should be
applied when validating the `value`.
Review Comment:
Yes - I considered this as well. If
`UnionSchema::find_schema_with_known_schemata()` were not to use
`validate_internal()`, then it would need another mechanism to select the right
schema for a `types::Value`, given a set of schemas.
I suppose this could be done, but this seems like a larger lift than the
current fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
