CamilAbraham commented on code in PR #2439:
URL: https://github.com/apache/avro/pull/2439#discussion_r1295886622
##########
lang/csharp/src/apache/main/IO/BinaryDecoder.cs:
##########
@@ -26,14 +26,25 @@ namespace Avro.IO
public partial class BinaryDecoder : Decoder, IDisposable
{
private readonly Stream stream;
+ private readonly bool ownStream;
/// <summary>
/// Initializes a new instance of the <see cref="BinaryDecoder"/>
class.
/// </summary>
/// <param name="stream">Stream to decode.</param>
- public BinaryDecoder(Stream stream)
+ public BinaryDecoder(Stream stream) : this(stream, false)
+ {
+ }
+
+ /// <summary>
+ /// Initializes a new instance of the <see cref="BinaryDecoder"/>
class.
+ /// </summary>
+ /// <param name="stream">Stream to decode.</param>
+ /// <param name="ownStream">Leave stream open after disposing the
object.</param>
Review Comment:
This makes a lot of sense. Will change the descriptions and Dispose logic of
the encoder and decoder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
