databius commented on PR #2568: URL: https://github.com/apache/avro/pull/2568#issuecomment-1779662243
> Thank you for implementing this! > > The idea is good, but plugin mojos should have one task. > > Can you please create separate mojos for each of the two new actions? Agree that plugin mojos should have single responsibility. But the mojo names confused me. Since https://github.com/apache/avro/pull/1589, we have: - IDLMojo - @goal idl - Generate Java classes and interfaces from AvroIDL files (.avdl) - IDLProtocolMojo - @goal idl-protocol - The old version of IDLMojo `IDLMojo` looks like a generic IDL tool so I added the new actions to it. I think it would be clearer if it had a more meaningful name likes `IDL2JavaMojo` And the new Mojos might be: - `IDL2ProtocolMojo` - @goal idl-2-protocol - Generate Json protocol from Avro IDL files (.avdl) - `IDL2SchemaMojo` - @goal idl-2-schema - Generate Json Schema from Avro IDL files (.avdl) Are they OK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
