martin-g commented on code in PR #2567:
URL: https://github.com/apache/avro/pull/2567#discussion_r1372082897
##########
lang/rust/avro/src/de.rs:
##########
@@ -1315,4 +1323,67 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_avro_3892_deserialize_string_from_bytes() -> TestResult {
+ let raw_value = vec![1, 2, 3, 4];
+ let value = Value::Bytes(raw_value.clone());
+ let result = from_value::<String>(&value)?;
+ assert_eq!(result, String::from_utf8(raw_value)?);
+ Ok(())
+ }
+
+ #[test]
+ fn test_avro_3892_deserialize_str_from_bytes() -> TestResult {
+ let raw_value = &[1, 2, 3, 4];
+ let value = Value::Bytes(raw_value.to_vec());
+ let result = from_value::<&str>(&value)?;
+ assert_eq!(result, std::str::from_utf8(raw_value)?);
+ Ok(())
+ }
+
+ struct Bytes(Vec<u8>);
+
+ impl<'de> Deserialize<'de> for Bytes {
+ fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+ where
+ D: serde::Deserializer<'de>,
+ {
+ struct BytesVisitor;
+ impl<'de> serde::de::Visitor<'de> for BytesVisitor {
+ type Value = Bytes;
+
+ fn expecting(&self, formatter: &mut std::fmt::Formatter) ->
std::fmt::Result {
+ formatter.write_str("a byte array")
+ }
+
+ fn visit_bytes<E>(self, v: &[u8]) -> Result<Self::Value, E>
+ where
+ E: serde::de::Error,
+ {
+ Ok(Bytes(v.to_vec()))
+ }
+ }
+ deserializer.deserialize_bytes(BytesVisitor)
+ }
+ }
+
+ #[test]
+ fn test_avro_3892_deserialize_bytes_from_decimal() -> TestResult {
+ let expeced_bytes = BigInt::from(123456789).to_signed_bytes_be();
Review Comment:
```suggestion
let expected_bytes = BigInt::from(123456789).to_signed_bytes_be();
```
##########
lang/rust/avro/src/de.rs:
##########
@@ -1315,4 +1323,67 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_avro_3892_deserialize_string_from_bytes() -> TestResult {
+ let raw_value = vec![1, 2, 3, 4];
+ let value = Value::Bytes(raw_value.clone());
+ let result = from_value::<String>(&value)?;
+ assert_eq!(result, String::from_utf8(raw_value)?);
+ Ok(())
+ }
+
+ #[test]
+ fn test_avro_3892_deserialize_str_from_bytes() -> TestResult {
+ let raw_value = &[1, 2, 3, 4];
+ let value = Value::Bytes(raw_value.to_vec());
+ let result = from_value::<&str>(&value)?;
+ assert_eq!(result, std::str::from_utf8(raw_value)?);
+ Ok(())
+ }
+
+ struct Bytes(Vec<u8>);
+
+ impl<'de> Deserialize<'de> for Bytes {
+ fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+ where
+ D: serde::Deserializer<'de>,
+ {
+ struct BytesVisitor;
+ impl<'de> serde::de::Visitor<'de> for BytesVisitor {
+ type Value = Bytes;
+
+ fn expecting(&self, formatter: &mut std::fmt::Formatter) ->
std::fmt::Result {
+ formatter.write_str("a byte array")
+ }
+
+ fn visit_bytes<E>(self, v: &[u8]) -> Result<Self::Value, E>
+ where
+ E: serde::de::Error,
+ {
+ Ok(Bytes(v.to_vec()))
+ }
+ }
+ deserializer.deserialize_bytes(BytesVisitor)
+ }
+ }
+
+ #[test]
+ fn test_avro_3892_deserialize_bytes_from_decimal() -> TestResult {
+ let expeced_bytes = BigInt::from(123456789).to_signed_bytes_be();
+ let value = Value::Decimal(Decimal::from(&expeced_bytes));
+ let raw_bytes = from_value::<Bytes>(&value)?;
+ assert_eq!(raw_bytes.0, expeced_bytes);
+ Ok(())
+ }
+
+ #[test]
+ fn test_avro_3892_deserialize_bytes_from_uuid() -> TestResult {
+ let uuid_str = "10101010-2020-2020-2020-101010101010";
+ let expected_bytes = Uuid::parse_str(uuid_str)?.as_bytes().to_vec();
Review Comment:
Dunno!
I have to check what `Uuid::as_bytes()` does. I'll check tomorrow!
But feel free to propose a PR with a fix if you think it is wrong!
##########
lang/rust/avro/src/de.rs:
##########
@@ -1315,4 +1323,67 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_avro_3892_deserialize_string_from_bytes() -> TestResult {
+ let raw_value = vec![1, 2, 3, 4];
+ let value = Value::Bytes(raw_value.clone());
+ let result = from_value::<String>(&value)?;
+ assert_eq!(result, String::from_utf8(raw_value)?);
+ Ok(())
+ }
+
+ #[test]
+ fn test_avro_3892_deserialize_str_from_bytes() -> TestResult {
+ let raw_value = &[1, 2, 3, 4];
+ let value = Value::Bytes(raw_value.to_vec());
+ let result = from_value::<&str>(&value)?;
+ assert_eq!(result, std::str::from_utf8(raw_value)?);
+ Ok(())
+ }
+
+ struct Bytes(Vec<u8>);
+
+ impl<'de> Deserialize<'de> for Bytes {
+ fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+ where
+ D: serde::Deserializer<'de>,
+ {
+ struct BytesVisitor;
+ impl<'de> serde::de::Visitor<'de> for BytesVisitor {
+ type Value = Bytes;
+
+ fn expecting(&self, formatter: &mut std::fmt::Formatter) ->
std::fmt::Result {
+ formatter.write_str("a byte array")
+ }
+
+ fn visit_bytes<E>(self, v: &[u8]) -> Result<Self::Value, E>
+ where
+ E: serde::de::Error,
+ {
+ Ok(Bytes(v.to_vec()))
+ }
+ }
+ deserializer.deserialize_bytes(BytesVisitor)
+ }
+ }
+
+ #[test]
+ fn test_avro_3892_deserialize_bytes_from_decimal() -> TestResult {
+ let expeced_bytes = BigInt::from(123456789).to_signed_bytes_be();
+ let value = Value::Decimal(Decimal::from(&expeced_bytes));
+ let raw_bytes = from_value::<Bytes>(&value)?;
+ assert_eq!(raw_bytes.0, expeced_bytes);
+ Ok(())
Review Comment:
Please add tests also for the `Value::Bytes` and `Value::Fixed`, and
`Value::Union` with them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
