marcosschroh commented on code in PR #2600:
URL: https://github.com/apache/avro/pull/2600#discussion_r1412302944
##########
lang/rust/avro/src/schema.rs:
##########
@@ -206,42 +206,6 @@ impl From<&types::Value> for SchemaKind {
}
}
-// Implement `Display` for `SchemaKind`.
Review Comment:
Well, I think it will display `Ref`. Because `SchemaKind` is created with
[strum_discriminant](https://docs.rs/strum/latest/strum/derive.EnumDiscriminants.html)
then the `name` of a `Ref` won't be used. I think an error as `The
{schema_type} should have been Ref` is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
