[ 
https://issues.apache.org/jira/browse/AVRO-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817678#comment-17817678
 ] 

ASF subversion and git services commented on AVRO-3939:
-------------------------------------------------------

Commit ab9d9a582d1783aec8128d8a0626aea4f11d3f35 in avro's branch 
refs/heads/avro-3939-custom-schemata-comparators from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ab9d9a582 ]

AVRO-3939: Temporarily use StructFieldComparator as default

Implement compare_fields()

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>


> [Rust] Make it possible to use custom schema comparators
> --------------------------------------------------------
>
>                 Key: AVRO-3939
>                 URL: https://issues.apache.org/jira/browse/AVRO-3939
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: rust
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently comparing two schemas for equality compares their canonical forms - 
> https://github.com/apache/avro/blob/main/lang/rust/avro/src/schema.rs#L160.
> I.e. the schemas are first serialized to their canonical forms and then 
> compared as strings.
> The main issue here is the performance! The serialization takes it time!
> Comparing the schemas field by field (following the same rules as the 
> canonical forms - 
> https://avro.apache.org/docs/1.11.1/specification/#parsing-canonical-form-for-schemas)
>  will return as soon as a field is different. For example: record schema with 
> a different name will return false without comparing all the fields.
> Another request by users is to compare the schemas even with fields which are 
> not part of the canonical form, e.g. the custom attributes - 
> https://github.com/apache/avro/pull/2708#discussion_r1467183416



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to