martin-g commented on code in PR #2270:
URL: https://github.com/apache/avro/pull/2270#discussion_r1222841365
##########
lang/c++/api/Node.hh:
##########
@@ -40,30 +40,38 @@ class GenericDatum;
using NodePtr = std::shared_ptr<Node>;
class AVRO_DECL Name {
+ struct Aliases;
+
std::string ns_;
std::string simpleName_;
+ std::unique_ptr<Aliases> aliases_;
public:
- Name() = default;
- explicit Name(const std::string &fullname);
- Name(std::string simpleName, std::string ns) : ns_(std::move(ns)),
simpleName_(std::move(simpleName)) { check(); }
+ Name();
+ explicit Name(const std::string &name);
+ Name(std::string simpleName, std::string ns);
+ Name(const Name& other);
+ Name& operator=(const Name& other);
+ Name(Name&& other);
+ Name& operator=(Name&& other);
+ ~Name();
std::string fullname() const;
const std::string &ns() const { return ns_; }
const std::string &simpleName() const { return simpleName_; }
+ const std::vector<std::string>& aliases() const;
Review Comment:
```suggestion
const std::vector<std::string> &aliases() const;
```
for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
