[
https://issues.apache.org/jira/browse/AVRO-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Tzvetanov Grigorov resolved AVRO-3961.
---------------------------------------------
Fix Version/s: 1.12.0
Assignee: Sahil Kang
Resolution: Fixed
> Add AVRO_INVALID to avro_type_t
> -------------------------------
>
> Key: AVRO-3961
> URL: https://issues.apache.org/jira/browse/AVRO-3961
> Project: Apache Avro
> Issue Type: Improvement
> Components: c
> Reporter: Sahil Kang
> Assignee: Sahil Kang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.12.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> There are preexisting warnings in
> [schema.c|https://github.com/apache/avro/blob/9c7e14d89f80f7bea9c4d67d3ae98b86b5cff166/lang/c/src/schema.c#L879-L886]
> and
> [datum_value.c|https://github.com/apache/avro/blob/9c7e14d89f80f7bea9c4d67d3ae98b86b5cff166/lang/c/src/datum_value.c#L83-L94]
> stemming from the fact that
> [avro_type_t|https://github.com/apache/avro/blob/9c7e14d89f80f7bea9c4d67d3ae98b86b5cff166/lang/c/src/avro/basics.h#L28-L44]
> does not have a default/invalid state
> However, since the public interface already exposes [EINVAL as an
> avro_type_t|https://github.com/apache/avro/blob/9c7e14d89f80f7bea9c4d67d3ae98b86b5cff166/lang/c/src/datum_value.c#L95],
> we can add an {{AVRO_INVALID = EINVAL}} branch to {{avro_type_t}} while
> maintaining ABI compatibility
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
