spektom commented on code in PR #843:
URL: https://github.com/apache/avro/pull/843#discussion_r1590036044
##########
lang/c/src/schema.h:
##########
@@ -76,12 +78,30 @@ struct avro_link_schema_t {
avro_schema_t to;
};
+struct avro_bytes_schema_t {
+ struct avro_obj_t obj;
+ avro_logical_schema_t *logical_type;
+};
Review Comment:
Thanks for looking at the PR.
AFAIU, logical type is a non-mandatory annotation of a physical type, which
is why [avro_type_t] is left without logical schema branches. For this reason,
[avro_logical_schema_t] is implemented as a standalone decorator. Doesn't this
make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
