martin-g commented on code in PR #2934:
URL: https://github.com/apache/avro/pull/2934#discussion_r1623875468
##########
lang/java/avro/src/test/java/org/apache/avro/reflect/TestReflect.java:
##########
@@ -1171,6 +1171,7 @@ public static class NullableStringable {
@Test
void nullableStringableField() throws Exception {
+ System.setProperty("org.apache.avro.TRUSTED_PACKAGES", "*");
Review Comment:
Should this be reverted in a `finally` ?
Because currently it will leak to other tests too.
##########
lang/java/avro/src/test/java/org/apache/avro/reflect/TestReflectData.java:
##########
@@ -40,6 +41,17 @@
import static org.junit.jupiter.api.Assertions.assertThrows;
public class TestReflectData {
+
+ @Test
+ void trustedPackages() throws Exception {
+ Schema schema = new Schema.Parser().parse(new
File("target/test-classes/schema-trusted-packages.json"));
+
+ Schema.Field field = schema.getField("value");
+ System.out.println(field);
+
+ System.out.println(schema);
Review Comment:
This test looks like a playground.
It should be either finished (e.g. by using assertions) or removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
