[ 
https://issues.apache.org/jira/browse/AVRO-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854463#comment-17854463
 ] 

José Joaquín Atria commented on AVRO-1830:
------------------------------------------

This change seems reasonable to me. It would be good to have a test case to go 
with it.

The only thing I'm not sure about is whether we would want the default 'null' 
string to be in `Avro::DataFileReader::read_file_header` or in 
`Avro::DataFile::is_codec_valid`. I would personally have made the change in 
the later, but doing it in the former seems more consistent with the behaviour 
of the Avro::DataFileWriter constructor.

Either way, this change makes the code more compliant with the spec.

> Avro-Perl DataFileReader chokes when avro.codec is absent
> ---------------------------------------------------------
>
>                 Key: AVRO-1830
>                 URL: https://issues.apache.org/jira/browse/AVRO-1830
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: perl
>    Affects Versions: 1.8.0
>            Reporter: SK Liew
>            Priority: Minor
>         Attachments: Avro-1830.patch
>
>
> When a container does not specify its "avro.codec", it should be assumed to 
> be "null". An exception is thrown when I try to read such a container using 
> Avro::DataFileReader. The error happens at Avro/DataFileReader.pm line 101.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to