Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677714491
##########
lang/c++/test/buffertest.cc:
##########
@@ -34,19 +34,18 @@ using detail::kMinBlockSize;
using std::cout;
using std::endl;
+// Make a string of repeating 0123456789ABCDEF0123456789...
std::string makeString(size_t len) {
- std::string newstring;
- newstring.reserve(len);
+ std::string result;
+ result.reserve(len);
+
+ constexpr auto chars = "0123456789ABCDEF";
Review Comment:
It's resolved to `const char*`, `constexpr auto chars[]` isn't legal,
switched to `constexpr char chars[]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
