[ https://issues.apache.org/jira/browse/AVRO-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866713#comment-17866713 ]
ASF subversion and git services commented on AVRO-3631: ------------------------------------------------------- Commit 612af8b303a5170dd1f052b484a8e41860cfed7f in avro's branch refs/heads/avro-3631/fix-fixed-serialization from Rik Heijdens [ https://gitbox.apache.org/repos/asf?p=avro.git;h=612af8b30 ] AVRO-3631: Add test for serializing fixed fields This test-case mainly demonstrates the issue reported in AVRO-3631. It is unclear to me whether we should actually expect the serializer to serialize to a Value::Fixed right away given that Schema information is not available at this stage. > Fix serialization of structs containing Fixed fields > ---------------------------------------------------- > > Key: AVRO-3631 > URL: https://issues.apache.org/jira/browse/AVRO-3631 > Project: Apache Avro > Issue Type: Bug > Components: rust > Reporter: Rik Heijdens > Priority: Major > Labels: pull-request-available > Time Spent: 4h > Remaining Estimate: 0h > > Consider the following minimal Avro Schema: > {noformat} > { > "type": "record", > "name": "TestStructFixedField", > "fields": [ > { > "name": "field", > "type": { > "name": "field", > "type": "fixed", > "size": 6 > } > } > ] > } > {noformat} > In Rust, I might represent this schema with the following struct: > {noformat} > #[derive(Debug, Serialize, Deserialize)] > struct TestStructFixedField { > field: [u8; 6] > } > {noformat} > I would then expect to be able to use `apache_avro::to_avro_datum()` to > convert an instance of `TestStructFixedField` into an `Vec<u8>` using an > instance of `Schema` initialized from the schema listed above. > However, this fails because the `Value` produced by `apache_avro::to_value()` > represents `field` as an `Value::Array<Value::Int>` rather than a > `Value::Fixed<6, Vec<u8>` which does not pass schema validation. > I believe that there are two options to fix this: > 1. Allow Value::Array<Vec<Value::Int>> to pass validation if the array has > the expected length, and none of the contents of the array are out-of-range > for u8. If we go down this route, the implementation of `to_avro_datum()` > will have to take care of converting Value::Int to u8 when converting into > bytes. > 2. Update `apache_avro::to_value()` such that fixed length arrays are > converted into `Value::Fixed<N, Vec<u8>>` rather than `Value::Array`. -- This message was sent by Atlassian Jira (v8.20.10#820010)