xxchan commented on PR #3051: URL: https://github.com/apache/avro/pull/3051#issuecomment-2254099496
1. This behavior has existed in java (the de-facto standard) for >10 years, and in the real world such schema do exists. So I don't think there are any practical reason why the Rust implementation should reject it. https://github.com/apache/avro/blob/42c54e68120bb5c2393954b5990a0aa3b3960510/lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj#L318-L322 2. Perhaps we can "guess the intention" of the spec: First, float/double are defined as IEEE 754 floating-point number, and NaN/Inf should be valid values; Then JSON encoding and the default value encoding are the same; JSON encoding should have the same position and allow all valid values. Therefore, I would say this is not a "new feature", but it's vagueness in the spec. We should fix the spec instead of the Rust implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
