clemensv commented on PR #2888: URL: https://github.com/apache/avro/pull/2888#issuecomment-2312321695
> CodeQL found more than 20 potential problems in the proposed changes. Check the [Files changed](/apache/avro/pull/2888/files) tab for more details. Interesting. The tool contains about upcasts of the form ``` (T)(object)((DateTime)logicalValue).ToUniversalTime(); ``` whereby the upcast to object from DateTime is flagged. The cast is required for the cast to (T) to compile and will indeed fail at runtime if there's a mismatch. So that looks like a false positive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
