martin-g commented on code in PR #3168:
URL: https://github.com/apache/avro/pull/3168#discussion_r1773256186
##########
lang/c++/test/SchemaTests.cc:
##########
@@ -355,7 +355,8 @@ const char *roundTripSchemas[] = {
{"name":"f1","type":"long","extra_field":"1"},
{"name":"f2","type":"int","extra_field1":"21","extra_field2":"22"}
]
- })"
+ })",
+ R"({"type":"array","items":"long","extra":"1"})"
Review Comment:
There is an error:
```
unknown location(0): fatal error: in "Avro C__ unit tests for
schemas/avro__schema__testBasic_35": avro::Exception: Invalid type. Expected
"string" actual long
/home/runner/work/avro/avro/lang/c++/test/SchemaTests.cc(428): last
checkpoint: {"type": "array", "items": "long", "extra attribute": 1}
```
Where does `attribute` come from in `"extra attribute"` ?!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
