KalleOlaviNiemitalo commented on PR #3194: URL: https://github.com/apache/avro/pull/3194#issuecomment-2401990044
`stringClassCache` was first added in <https://github.com/apache/avro/commit/a3b38ebfdaf93eb77860fe80540bbc788e9589df>, as part of [AVRO-1268](https://issues.apache.org/jira/browse/AVRO-1268) implementation. [AVRO-3531](https://issues.apache.org/jira/browse/AVRO-3531) was a thread safety bug. Its fix <https://github.com/apache/avro/pull/1719> changed the types of the caches and moved them into `static class ReaderCache`, but did not add any new caches. I don't know whether `stringClassCache` is beneficial now; but AVRO-3531 doesn't look like a reason to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
