martin-g commented on PR #3266: URL: https://github.com/apache/avro/pull/3266#issuecomment-2575614953
I am not C++ dev/user, so my opinion is even more irrelevant :-) My 2c: - the PR becomes bigger and since there are not many C++ users reviewing/commenting on it the chances to be merged become smaller :-/ - in Rust and Java I prefer to use a simple enum instead of boolean parameter. 1) it is more clear to read `xyz(Enum.Variant1)` instead of `xyz(false)`; 2) it is easy to add more logic by adding more variants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
