wgtmac commented on code in PR #3293: URL: https://github.com/apache/avro/pull/3293#discussion_r1920134170
########## lang/c++/CMakeLists.txt: ########## @@ -81,11 +78,8 @@ if (AVRO_ADD_PROTECTOR_FLAGS) endif () endif () -if (AVRO_BUILD_TESTS OR AVRO_BUILD_EXECUTABLES) - find_package (Boost 1.38 REQUIRED - COMPONENTS filesystem iostreams program_options system) -else () - find_package (Boost 1.38 REQUIRED COMPONENTS iostreams) +if (AVRO_BUILD_TESTS OR AVRO_USE_BOOST) + find_package (Boost 1.38 REQUIRED COMPONENTS system) Review Comment: After some investigation, I think the `system` component is required for `boost/asio`, so let's keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
