KalleOlaviNiemitalo commented on code in PR #3285:
URL: https://github.com/apache/avro/pull/3285#discussion_r1924234072
##########
lang/java/avro/src/main/java/org/apache/avro/generic/PrimitivesArrays.java:
##########
@@ -550,7 +550,7 @@ public void add(int location, Double o) {
if (o == null) {
return;
}
- this.add(location, o.floatValue());
+ this.add(location, (double) o);
Review Comment:
I don't have too much experience with Java. What is boxed here? The
parameter was declared as `Double o`. AFAICT, `(double) o` here is an unboxing
conversion as defined in
<https://docs.oracle.com/javase/specs/jls/se17/html/jls-5.html#jls-5.1.8>, and
it's equivalent to `r.doubleValue()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
