jhump commented on code in PR #3266:
URL: https://github.com/apache/avro/pull/3266#discussion_r1932364778
##########
lang/c++/include/avro/CustomAttributes.hh:
##########
@@ -19,27 +19,62 @@
#ifndef avro_CustomAttributes_hh__
#define avro_CustomAttributes_hh__
-#include "Config.hh"
#include <iostream>
#include <map>
#include <optional>
#include <string>
+#include "Config.hh"
+
namespace avro {
// CustomAttributes class stores avro custom attributes.
// Each attribute is represented by a unique name and value.
// User is supposed to create CustomAttributes object and then add it to
Schema.
class AVRO_DECL CustomAttributes {
+
public:
- // Retrieves the custom attribute json entity for that attributeName,
returns an
- // null if the attribute doesn't exist.
+ enum class ValueMode : uint8_t {
+ // When a CustomAttributes is created using this mode, all values are
expected
+ // to be strings. The value should not be quoted, but any interior
quotes and
+ // special characters (such as newlines) must be escaped.
+ STRING
+ [[deprecated("The JSON ValueMode is less error-prone and less
limited.")]],
Review Comment:
I've added some info about the versions to the deprecation messages, but it
could probably use some tweaking, particularly with what to say about the
no-arg constructor and how that should be handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
