martin-g commented on code in PR #3305: URL: https://github.com/apache/avro/pull/3305#discussion_r1933501161
########## .github/workflows/ci.yml: ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. Review Comment: Please rename the file to something related to Gradle ########## .github/workflows/gradle-compatibility.yml: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. + +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. + +name: Gradle Compatibility Tests +on: [push, pull_request] +jobs: + test: + name: "Compatibility: gradle ${{ matrix.gradle }}/java ${{ matrix.java }}" + runs-on: "ubuntu-latest" + strategy: + matrix: + avro: ["1.11.0"] + gradle: [ + "5.1", "5.1.1", "5.2", "5.2.1", "5.3", "5.3.1", "5.4", "5.4.1", "5.5", "5.5.1", "5.6", "5.6.1", "5.6.2", "5.6.3", "5.6.4", Review Comment: Why v5.1 ? Isn't it too old ? I am not Gradle user but AFAIK 8.x is the current version. I ask because this PR increases the CI jobs for Java from less than 10 to 130+ ########## .github/workflows/avro-compatibility.yml: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. + +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. + +name: Avro Compatibility Tests +on: [push, pull_request] +jobs: + test: + name: "Compatibility: avro ${{ matrix.avro }}/gradle ${{ matrix.gradle }}" + runs-on: "ubuntu-latest" + strategy: + matrix: + avro: ["1.11.0", "1.11.1"] + gradle: ["5.1", "7.6"] Review Comment: Why v5.1 ? Isn't it too old ? I am not Gradle user but AFAIK 8.x is the current version. I ask because this PR increases the CI jobs for Java from less than 10 to 130+ ########## .github/workflows/publish.yml: ########## @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. + +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. + +name: Publish package to the Maven Central Repository Review Comment: This workflow is not needed. The pubilsh is done as part of the release process. ########## .github/workflows/ci.yml: ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. + +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. + +name: CI Build +on: [push, pull_request] +jobs: + build: + name: "Build" + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 Review Comment: Please use latest versions of the github actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
