[ 
https://issues.apache.org/jira/browse/AVRO-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benedikt Werner updated AVRO-4119:
----------------------------------
    Description: 
In AVRO-3641, the createNullSafeAnnotations option was added to the Java code 
generator to enable generating @Nullable and @NotNull annotations depending on 
a field's nullability.

However, this always generates JetBrains nullability annotations, which isn't 
ideal for projects using one of the many other nullability annotations.

A universal solution would be to make the exact annotations to generate 
configurable, defaulting to the JetBrains annotations for 
backwards-compatibility.

I already created a PR with a proposed implementation.

  was:
In AVRO-3641, the createNullSafeAnnotations option was added to the Java code 
generator to enable generating @Nullable and @NotNull annotations depending on 
a field's nullability.

However, this always generates JetBrains nullability annotations, which isn't 
ideal for projects using one of the many other nullability annotations.

A universal solution would be to make the exact annotations to generate 
configurable, defaulting to the JetBrains annotations for 
backwards-compatibility.

I will create a PR with a proposed implementation shortly.


> Make Nullable and NotNull annotations configurable
> --------------------------------------------------
>
>                 Key: AVRO-4119
>                 URL: https://issues.apache.org/jira/browse/AVRO-4119
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Benedikt Werner
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In AVRO-3641, the createNullSafeAnnotations option was added to the Java code 
> generator to enable generating @Nullable and @NotNull annotations depending 
> on a field's nullability.
> However, this always generates JetBrains nullability annotations, which isn't 
> ideal for projects using one of the many other nullability annotations.
> A universal solution would be to make the exact annotations to generate 
> configurable, defaulting to the JetBrains annotations for 
> backwards-compatibility.
> I already created a PR with a proposed implementation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to