wgtmac commented on code in PR #3324: URL: https://github.com/apache/avro/pull/3324#discussion_r1973061463
########## lang/c++/include/avro/NodeImpl.hh: ########## @@ -235,9 +235,9 @@ using NodeImplSymbolic = NodeImpl<HasName, NoLeaves, NoLeafNames, NoAttributes, using NodeImplRecord = NodeImpl<HasName, MultiLeaves, LeafNames, MultiAttributes, NoSize>; using NodeImplEnum = NodeImpl<HasName, NoLeaves, LeafNames, NoAttributes, NoSize>; Review Comment: Do you want me to change that as well? Similar questions to `symbolic` and `union`. I don't have strong opinions but the spec should support all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
