mkeskells commented on code in PR #3307:
URL: https://github.com/apache/avro/pull/3307#discussion_r1977346475
##########
lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java:
##########
@@ -1515,34 +1515,45 @@ else if (value instanceof Utf8) {
}
- /*
+ /**
* Called to create new array instances. Subclasses may override to use a
- * different array implementation. By default, this returns a {@link
- * GenericData.Array}.
+ * different array implementation. By default, this returns a
+ * {@link GenericData.Array}.
+ *
+ * @param old the old array instance to reuse, if possible. If the old
array
+ * is an appropriate type, it may be cleared and returned.
+ * @param size the size of the array to create.
+ * @param schema the schema of the array elements.
Review Comment:
Was on holiday last week, so didn't respond earlier
@opwvhk The returned schema check was just using `==` (identity check)
rather than `.equals` (equality check) to avoid the cost explicitly
Can you confirm if this is OK, or should be removed as a check
My issue with he collection interface, is that reusing a `Set` will have
different semantics that returning a new `List`
I guess thing sort of work OK ATM, but always wary about changing code when
I know so little of the expectation of the behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
