martin-g commented on code in PR #139:
URL: https://github.com/apache/avro-rs/pull/139#discussion_r1979000178
##########
avro/src/de.rs:
##########
@@ -230,6 +241,60 @@ impl<'de> de::VariantAccess<'de> for EnumDeserializer<'de>
{
}
}
+impl<'de> de::EnumAccess<'de> for UnionDeserializer<'de> {
+ type Error = Error;
+ type Variant = Self;
Review Comment:
I am not sure this type is helpful here.
Its usage below (Self::Variant) makes it more confusing.
Can we use just `Self` ?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
