Gerrit0 commented on code in PR #3364:
URL: https://github.com/apache/avro/pull/3364#discussion_r2061668392
##########
lang/c++/include/avro/DataFile.hh:
##########
@@ -39,7 +39,11 @@ enum Codec {
DEFLATE_CODEC,
#ifdef SNAPPY_CODEC_AVAILABLE
- SNAPPY_CODEC
+ SNAPPY_CODEC,
+#endif
+
+#ifdef ZSTD_CODEC_AVAILABLE
+ ZSTD_CODEC
Review Comment:
It seems to me that these enum values should really have an explicit value
to avoid potential confusion where "2" could mean either depending on what
preprocessor definitions are set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
