[
https://issues.apache.org/jira/browse/AVRO-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949321#comment-17949321
]
ASF subversion and git services commented on AVRO-4119:
-------------------------------------------------------
Commit 067c44024c3db832e731c051ba0178f0c4f18a04 in avro's branch
refs/heads/dependabot/maven/lang/java/org.apache.thrift-libthrift-0.21.0 from
Benedikt Werner
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=067c44024c ]
AVRO-4119: [java] Make Nullable and NotNull annotations configurable (#3312)
Add nullSafeAnnotationNullable and nullSafeAnnotationNotNull
configuration options to allow specifying the exact annotations
to use when createNullSafeAnnotations is enabled.
This allows using annotations besides the JetBrains annotations
(which remain the default for backward-compatibility).
Co-authored-by: Oscar Westra van Holthe - Kind <[email protected]>
> Make Nullable and NotNull annotations configurable
> --------------------------------------------------
>
> Key: AVRO-4119
> URL: https://issues.apache.org/jira/browse/AVRO-4119
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
> Reporter: Benedikt Werner
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In AVRO-3641, the createNullSafeAnnotations option was added to the Java code
> generator to enable generating @Nullable and @NotNull annotations depending
> on a field's nullability.
> However, this always generates JetBrains nullability annotations, which isn't
> ideal for projects using one of the many other nullability annotations.
> A universal solution would be to make the exact annotations to generate
> configurable, defaulting to the JetBrains annotations for
> backwards-compatibility.
> I already created a PR with a proposed implementation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
