thiru-mg commented on code in PR #3412:
URL: https://github.com/apache/avro/pull/3412#discussion_r2160211348


##########
lang/c++/include/avro/DataFile.hh:
##########
@@ -71,8 +76,6 @@ class AVRO_DECL DataFileWriterBase {
     const DataFileSync sync_;
     int64_t objectCount_;
 
-    typedef std::map<std::string, std::vector<uint8_t>> Metadata;

Review Comment:
   In order to avoid backward incompatibility I think we should just have a 
class-level typedef that is an alias for the namespace-level typedef.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to