martin-g commented on PR #238:
URL: https://github.com/apache/avro-rs/pull/238#issuecomment-3102844002
> The annoying thing about `maybe_async` is that it will break builds. If a
crate is depending on two libraries who both depend on avro, but one enabes
sync and the other async. The crate will not build.
Didn't they solve this by introducing two features (is_async and is_sync)
and the macro generates separate module/function for each ?
E.g.
```rust
#[maybe_async]
async fn foo() {...}
```
would generate `fn_foo_sync()` when `is_sync` is enabled and `async fn
foo_async()` when `is_async` is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
