wgtmac commented on code in PR #3447:
URL: https://github.com/apache/avro/pull/3447#discussion_r2252914999
##########
lang/c++/CMakeLists.txt:
##########
@@ -79,15 +79,18 @@ if (AVRO_BUILD_TESTS OR AVRO_USE_BOOST)
find_package (Boost 1.70 REQUIRED CONFIG COMPONENTS system)
endif ()
-include(FetchContent)
-FetchContent_Declare(
- fmt
- GIT_REPOSITORY https://github.com/fmtlib/fmt.git
- GIT_TAG 10.2.1
- GIT_PROGRESS TRUE
- USES_TERMINAL_DOWNLOAD TRUE
-)
-FetchContent_MakeAvailable(fmt)
+find_package(fmt)
Review Comment:
As far as the projects that I have involved:
- Apache Arrow is still on C++17 but is trying to support both C++20 and
C++23: https://github.com/apache/arrow/issues/47207
- Apache Iceberg C++ (which depends on Avro C++) is on C++23 now:
https://github.com/apache/iceberg-cpp/blob/main/CMakeLists.txt#L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
