martin-g commented on code in PR #3479: URL: https://github.com/apache/avro/pull/3479#discussion_r2324539280
########## lang/c++/cmake/avro-cpp.pc.in: ########## @@ -0,0 +1,13 @@ +prefix=@CMAKE_INSTALL_PREFIX@ Review Comment: It is a required header for every file that would be part of the source distribution. The license is declared in the root folder of the source distribution in a file named LICENSE. > There is also a `License:` field we can add in the pkg-config file I think it is a good idea to use this field as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
