Sufflope commented on code in PR #311:
URL: https://github.com/apache/avro-rs/pull/311#discussion_r2419803622


##########
avro/src/schema.rs:
##########
@@ -2456,6 +2456,9 @@ pub mod derive {
     use super::*;
     use std::borrow::Cow;
 
+    pub use crate::writer::SERDE_FLATTEN;

Review Comment:
   In fact I need it public because, long story short I `impl 
AvroSchemaComponent` for one of my types and it is a flattened type, so I have 
to put this attribute manually in my hand-built schema. However I think a best 
approach would be to add a `pub fn set_serde_flatten_support(&mut self)` to 
`RecordSchema` which encapsulates these internal details of putting a custom 
attribute etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to