gahr commented on code in PR #3496:
URL: https://github.com/apache/avro/pull/3496#discussion_r2454219184
##########
lang/c++/test/StreamTests.cc:
##########
@@ -134,36 +135,34 @@ void testNonEmpty2(const TestData &td) {
Verify1()(*is, td.dataSize);
}
-static const char filename[] = "test_str.bin";
-
-struct FileRemover {
- const std::filesystem::path file;
- explicit FileRemover(const char *fn) : file(fn) {}
- ~FileRemover() { std::filesystem::remove(file); }
+struct FileGuard {
+ const std::filesystem::path path{ std::tmpnam(nullptr) };
Review Comment:
> Isn't `tmpnam` deprecated ?
I can't find references to its deprecation.
I don't think using `std::random_device` is a good idea, as it can be
implemented using a PRNG, i.e., two tests running at the same time would
produce the same number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
