[
https://issues.apache.org/jira/browse/AVRO-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041868#comment-18041868
]
ASF subversion and git services commented on AVRO-4210:
-------------------------------------------------------
Commit 6a72c2b0a8c2bc2050e3862f65f55026dde30355 in avro's branch
refs/heads/dependabot/nuget/lang/csharp/NUnit-4.4.0 from Jason
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=6a72c2b0a8 ]
AVRO-4210: Fix BinaryData.compareBytes to treat bytes as unsigned (#3537)
* Fixed BinaryData.compareBytes to treat bytes as unsigned
This is a regression fix introudeced in 1.12.1
added unit test
* Re-use the DirectBytes.compareBytes method to ensure consistency
This returns the comparision to be unsigned like it was in 1.12.0
This reverts commit 005ee8069dd69169e5c1842f0849d90373910b18.
> BinaryData.compareBytes should treat bytes as unsigned
> ------------------------------------------------------
>
> Key: AVRO-4210
> URL: https://issues.apache.org/jira/browse/AVRO-4210
> Project: Apache Avro
> Issue Type: Bug
> Affects Versions: 1.12.1
> Reporter: Ryan Skraba
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> A regression/changed behaviour in 1.12.1 -- we should be using
> Arrays.compareUnsigned
> When we merged AVRO-4045 and https://github.com/apache/avro/pull/3126/files
> to use the JDK method to compare bytes, signed/unsigned changed how these
> methods behaved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
