[ 
https://issues.apache.org/jira/browse/AVRO-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18043657#comment-18043657
 ] 

Ryan Skraba commented on AVRO-4219:
-----------------------------------

Cherry-picked to 
[branch-1.12|https://github.com/apache/avro/commit/026d678f1b0e28e95f8266e75346c1286889d9cd].
Cherry-picked to 
[branch-1.11|https://github.com/apache/avro/commit/bab1847cdec6fd49b3144a4ded41176ab580f619].


> [Build][Java] Apache RAT plugin is run when -PskipQuality is set
> ----------------------------------------------------------------
>
>                 Key: AVRO-4219
>                 URL: https://issues.apache.org/jira/browse/AVRO-4219
>             Project: Apache Avro
>          Issue Type: Task
>          Components: build, java
>    Affects Versions: 1.12.1
>            Reporter: Ryan Skraba
>            Assignee: Ryan Skraba
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.6, 1.12.2
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The RAT plugin is configured at the top-level pom.xml, but the 
> {{skipQuality}} profile is configured in {{lang/java}}.  As a consequence, 
> the rat plugin is run on all workflows that use Java, even when it's 
> unrelated to what is being built or under test (for example [C# 
> interoperability 
> tests|https://github.com/apache/avro/actions/runs/19940449174/job/57176535746#step:8:85]).
> {code}
> [INFO] --- apache-rat:0.16.1:check (default) @ avro-toplevel ---
> [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, 
> generated: 6, approved: 1534 licenses.
> [INFO] 
> {code}
> We should definitely be applying RAT checks at the top-level and to files in 
> the source distribution, but we should not be applying them when 
> {{-PskipQuality}} is explicitly set.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to