martin-g commented on code in PR #3600:
URL: https://github.com/apache/avro/pull/3600#discussion_r2649603933
##########
lang/c++/include/avro/Config.hh:
##########
@@ -19,25 +19,45 @@
#ifndef avro_Config_hh
#define avro_Config_hh
-// Windows DLL support
-
-#ifdef _WIN32
+#ifdef _MSC_VER
#pragma warning(disable : 4275 4251)
+#endif // _MSC_VER
+
+/*
+ * Symbol visibility macros:
+ * - AVRO_DLL_EXPORT annotation for exporting symbols
+ * - AVRO_DLL_IMPORT annotation for importing symbols
+ * - AVRO_DLL_HIDDEN annotation for hiding symbols
+ * - AVRO_DYN_LINK needs to be defined when compiling / linking avro as
dynamic library
+ * - AVRO_SOURCE needs to be defined when compiling avro as library
+ * - AVRO_DECL contains the correct symbol visibility annotation depending on
the two macros above
Review Comment:
```suggestion
* - AVRO_DECL contains the correct symbol visibility annotation depending
on AVRO_DYN_LINK and AVRO_SOURCE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
