jdarais commented on issue #378: URL: https://github.com/apache/avro-rs/issues/378#issuecomment-3695663260
Sounds good! I've been playing with some changes for this, so I'll get those together in a PR and include changes to `is_named`, too. As far as `is_named` is concerned, would you be opposed to deprecating (or simply removing) `SchemaKind::is_named`, and having `is_named` implemented directly on the `Schema` enum type instead? It looks like it would be difficult to implement `SchemaKind::is_named` correctly for logical types like `Decimal`, where the underlying type could be `fixed` (which is named) or `bytes` (which is not,) since underlying type information is not included in `SchemaKind`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
