martin-g commented on code in PR #3610:
URL: https://github.com/apache/avro/pull/3610#discussion_r2657582388
##########
lang/c++/impl/DataFile.cc:
##########
@@ -47,53 +47,183 @@ using std::array;
namespace {
const string AVRO_SCHEMA_KEY("avro.schema");
const string AVRO_CODEC_KEY("avro.codec");
-const string AVRO_NULL_CODEC("null");
-const string AVRO_DEFLATE_CODEC("deflate");
+const size_t minSyncInterval = 32;
Review Comment:
What unit is used here ? ms, secs, ...
A comment would be helpful!
##########
lang/c++/impl/DataFile.cc:
##########
@@ -47,53 +47,183 @@ using std::array;
namespace {
const string AVRO_SCHEMA_KEY("avro.schema");
const string AVRO_CODEC_KEY("avro.codec");
-const string AVRO_NULL_CODEC("null");
-const string AVRO_DEFLATE_CODEC("deflate");
+const size_t minSyncInterval = 32;
+const size_t maxSyncInterval = 1u << 30;
Review Comment:
My personal preference is to use the actual value (e.g. `1073741824`) and
add `// 1 << 30` as a comment. The code should be easier to read for the humans.
If `<<` is preferred then also change `32` above to `1 << 5`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
