frevib commented on code in PR #3614:
URL: https://github.com/apache/avro/pull/3614#discussion_r2669575735


##########
lang/java/gradle-plugin/src/main/kotlin/eu/eventloopsoftware/avro/gradle/plugin/tasks/AbstractCompileTask.kt:
##########
@@ -0,0 +1,71 @@
+package eu.eventloopsoftware.avro.gradle.plugin.tasks
+
+import org.gradle.api.provider.ListProperty
+import org.gradle.api.provider.Property
+import org.gradle.api.tasks.Input
+import org.gradle.api.tasks.SourceTask
+
+abstract class AbstractCompileTask : SourceTask() {

Review Comment:
   I think I'm starting to understand why `SourceTask` is maybe not the right 
fit. We now use `source` and `sourceDirectory`, which are used for the same 
things. If we use `DefaultTask` we don't have the issue of this ambiguity, and 
only use `sourceDirectory`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to