martin-g commented on code in PR #393:
URL: https://github.com/apache/avro-rs/pull/393#discussion_r2671091122
##########
avro_test_helper/src/lib.rs:
##########
@@ -56,10 +56,10 @@ pub struct TestError {}
/// A converter of any error into [TestError].
/// It is used to print better error messages in the tests.
/// Borrowed from
<https://bluxte.net/musings/2023/01/08/improving_failure_messages_rust_tests/>
-impl<Err: std::fmt::Display> From<Err> for TestError {
+impl<Err: std::fmt::Display + std::fmt::Debug> From<Err> for TestError {
Review Comment:
I tried but it failed with:
```
error[E0119]: conflicting implementations of trait `From<TestError>` for
type `TestError`
--> avro_test_helper/src/lib.rs:59:1
|
59 | impl<Err: std::fmt::Debug> From<Err> for TestError {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: conflicting implementation in crate `core`:
- impl<T> From<T> for T;
For more information about this error, try `rustc --explain E0119`.
error: could not compile `apache-avro-test-helper` (lib) due to 1 previous
error
warning: build failed, waiting for other jobs to finish...
```
Let me try harder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
