Kriskras99 commented on code in PR #397:
URL: https://github.com/apache/avro-rs/pull/397#discussion_r2692194430
##########
avro/src/bytes.rs:
##########
@@ -136,6 +164,29 @@ pub mod serde_avro_fixed {
use super::{BytesType, SER_BYTES_TYPE};
use serde::{Deserializer, Serializer};
+ use crate::{
+ Schema,
+ schema::{FixedSchema, Name, Names, Namespace},
+ };
+
+ /// Returns `Schema::Fixed(N)` named `serde_avro_fixed_{N}`
+ pub fn get_schema_in_ctxt<const N: usize>(
+ named_schemas: &mut Names,
+ enclosing_namespace: &Namespace,
+ ) -> Schema {
+ let name = Name::new(&format!("serde_avro_fixed_{N}"))
+ .expect("Name is valid")
+ .fully_qualified_name(enclosing_namespace);
Review Comment:
Should I also change what is generated by the `AvroSchema` derive? Then we
have it matching everywhere (I'll also make sure to update the docs of
`AvroSchemaComponent`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
