Kriskras99 commented on code in PR #411:
URL: https://github.com/apache/avro-rs/pull/411#discussion_r2704371968
##########
avro/src/schema/record/schema.rs:
##########
@@ -34,12 +34,22 @@ pub struct RecordSchema {
pub fields: Vec<RecordField>,
Review Comment:
```suggestion
#[builder(default)]
pub fields: Vec<RecordField>,
```
##########
avro/src/schema/record/schema.rs:
##########
@@ -34,12 +34,22 @@ pub struct RecordSchema {
pub fields: Vec<RecordField>,
/// The `lookup` table maps field names to their position in the `Vec`
/// of `fields`.
+ #[builder(skip = calculate_lookup_table(&fields))]
pub lookup: BTreeMap<String, usize>,
/// The custom attributes of the schema
- #[builder(default = BTreeMap::new())]
+ #[builder(default = Default::default())]
Review Comment:
```suggestion
#[builder(default)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
